Skip to content

fix: false positive with parameter name .history#4614

Merged
fzipi merged 1 commit into
coreruleset:mainfrom
EsadCetiner:fix-history-fp
Apr 16, 2026
Merged

fix: false positive with parameter name .history#4614
fzipi merged 1 commit into
coreruleset:mainfrom
EsadCetiner:fix-history-fp

Conversation

@EsadCetiner
Copy link
Copy Markdown
Member

Proposed changes

Matching on the .history file can cause substring matches like with history.history. Usually .history will never be stored within webroot and so you must try and escape out of webroot via a directory traversal or similar to access it, adding an boundary to .history should fix that issue. Fixes a false positive reported in CRS dev chat.

PR Checklist

  • I have read the CONTRIBUTING doc
  • I have added positive tests proving my fix/feature works as intended.
  • I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

Further comments

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

@github-actions
Copy link
Copy Markdown
Contributor

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@EsadCetiner EsadCetiner added the backport:lts-4.25 PR that must be backported to LTS release label Apr 16, 2026
Copy link
Copy Markdown
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EsadCetiner! LGTM.

@fzipi fzipi added this pull request to the merge queue Apr 16, 2026
Merged via the queue into coreruleset:main with commit 0885958 Apr 16, 2026
8 checks passed
@EsadCetiner EsadCetiner deleted the fix-history-fp branch April 17, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:lts-4.25 PR that must be backported to LTS release release:fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants