Skip to content

fix(942200): reduce false positives on payloads with comments#4608

Merged
fzipi merged 7 commits into
coreruleset:mainfrom
EsadCetiner:fix-942200
Apr 18, 2026
Merged

fix(942200): reduce false positives on payloads with comments#4608
fzipi merged 7 commits into
coreruleset:mainfrom
EsadCetiner:fix-942200

Conversation

@EsadCetiner
Copy link
Copy Markdown
Member

Proposed changes

PR #4476 fixed a false positive in a French address which accidently introduced a regression resulting in virtually all user-agents with a comma being blocked. While most issues were fixed in #4537 there are still issues with payloads that contain a comma but no whitespace.

I think we should backport this for the LTS since it's a common enough false positive.

PR Checklist

  • I have read the CONTRIBUTING doc
  • I have added positive tests proving my fix/feature works as intended.
  • I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

Further comments

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@EsadCetiner EsadCetiner added the backport:lts-4.25 PR that must be backported to LTS release label Apr 16, 2026
Copy link
Copy Markdown
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fzipi fzipi added this pull request to the merge queue Apr 18, 2026
Merged via the queue into coreruleset:main with commit 2c64b25 Apr 18, 2026
8 checks passed
@EsadCetiner EsadCetiner deleted the fix-942200 branch April 18, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:lts-4.25 PR that must be backported to LTS release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants