Skip to content

feat(933100): all HTTP headers should be checked#4603

Merged
EsadCetiner merged 2 commits into
coreruleset:mainfrom
touchweb-vincent:patch-15
Apr 7, 2026
Merged

feat(933100): all HTTP headers should be checked#4603
EsadCetiner merged 2 commits into
coreruleset:mainfrom
touchweb-vincent:patch-15

Conversation

@touchweb-vincent
Copy link
Copy Markdown
Contributor

@touchweb-vincent touchweb-vincent commented Apr 3, 2026

Proposed changes

Hello,

We have a concrete CVE example exploiting this via a PHP injection in an HTTP header: CVE-2026-1540

According to @fzipi ’s analysis available here: #4326 (comment) , the performance impact is minimal.

This adjustment has been implemented in our WAF for years, with no false positives observed over that period. We therefore consider it fully suitable for PL1.

What do you think?

PR Checklist

  • I have read the CONTRIBUTING doc
  • I have added positive tests proving my fix/feature works as intended.
  • I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

Further comments

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@EsadCetiner EsadCetiner added this pull request to the merge queue Apr 7, 2026
Merged via the queue into coreruleset:main with commit 820c78f Apr 7, 2026
8 checks passed
@touchweb-vincent touchweb-vincent deleted the patch-15 branch April 7, 2026 06:14
@fzipi fzipi added the release:new-feature This PR introduces a new feature label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:new-feature This PR introduces a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants