fix(932370): remove url from Windows LOLBIN command list#4587
Merged
Conversation
Contributor
|
📊 Quantitative test results for language: |
Contributor
|
yes, that is an extremly important pr, you opened if |
fzipi
reviewed
Mar 30, 2026
Member
fzipi
left a comment
There was a problem hiding this comment.
Can you add tests? Positive and negative, so we cover both cases. Thanks!
The 'url' entry in the Windows command list causes frequent false positives because 'url' appears in many legitimate contexts (URL parameters, API fields, content descriptions). The actual Windows url.dll is already covered by other patterns that include the full invocation context (rundll32 url.dll, etc.). Refs: coreruleset#4584
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a76afd8 to
f28854b
Compare
fzipi
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove
urlfrom the Windows living-off-the-land binary list in rule 932370.Why
The word 'url' appears in countless legitimate contexts: URL parameters, API fields, form data, content descriptions. This makes it a significant FP source.
The actual Windows
url.dllexploitation is already covered by other patterns that include the full invocation context (rundll32 url.dll,FileProtocolHandler).Files changed
regex-assembly/932370.ra— removedurlentryrules/REQUEST-932-APPLICATION-ATTACK-RCE.conf— regenerated via crs-toolchainRefs: #4584