fix(933150): remove is_int from PHP function names list#4585
Merged
Conversation
Contributor
|
📊 Quantitative test results for language: |
Contributor
|
yes |
Contributor
|
also is_int not senstive by itself in php just check is that an integer php > $integer = is_int(512);
php > echo($integer);
1
php > $name = is_int("RelunSec");
php > echo($name);
php > Nothing senstive on that, if it is an int return it else nothing |
Member
|
Can you add tests? Positive and negative, so we cover both cases. Thanks! |
is_int() is extremely common in non-attack contexts (form validation, type checking). Its presence causes false positives on legitimate PHP code and parameter values. Other type-checking functions like is_numeric, is_string remain as they are less commonly seen in user-facing input. Refs: coreruleset#4584
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ea98f8a to
794e901
Compare
fzipi
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove
is_intfromphp-function-names-933150.data.Why
is_int()is extremely common in non-attack contexts: form validation, type checking, API parameter handling. Its presence causes false positives on legitimate PHP code and parameter values.Other type-checking functions like
is_numeric,is_stringremain as they are less commonly seen in user-facing input.Testing
Quantitative testing against our dataset (4500 legitimate requests) showed this is one of the most common FP triggers.
Refs: #4584