Skip to content

feat: Expand Scanner Agents#4532

Merged
EsadCetiner merged 1 commit into
coreruleset:mainfrom
HackingRepo:patch-4
Mar 8, 2026
Merged

feat: Expand Scanner Agents#4532
EsadCetiner merged 1 commit into
coreruleset:mainfrom
HackingRepo:patch-4

Conversation

@HackingRepo
Copy link
Copy Markdown
Contributor

Proposed changes

That pull request expands the scanner agent lists

PR Checklist

  • [ x] I have read the CONTRIBUTING doc
  • [ x] I have added positive tests proving my fix/feature works as intended.
  • [ x] I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • [ x] In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

@HackingRepo HackingRepo changed the title Update scanners-user-agents.data Add more scanner agents Mar 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 7, 2026

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@HackingRepo HackingRepo changed the title Add more scanner agents feat: Update scanners-user-agents.data Mar 7, 2026
@HackingRepo HackingRepo changed the title feat: Update scanners-user-agents.data feat: Expand Scanner Agents Mar 7, 2026
Copy link
Copy Markdown
Member

@EsadCetiner EsadCetiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@EsadCetiner EsadCetiner added this pull request to the merge queue Mar 8, 2026
Merged via the queue into coreruleset:main with commit 4a2c60f Mar 8, 2026
12 of 14 checks passed
@HackingRepo HackingRepo deleted the patch-4 branch March 8, 2026 09:28
@fzipi fzipi added the release:new-detection In this PR we introduce a new detection label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:new-detection In this PR we introduce a new detection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants