Skip to content

fix(913100): adding OWASP Nettacker to known scanners list#4529

Merged
fzipi merged 1 commit into
coreruleset:mainfrom
securestep9:nettacker-scanner-add
Mar 7, 2026
Merged

fix(913100): adding OWASP Nettacker to known scanners list#4529
fzipi merged 1 commit into
coreruleset:mainfrom
securestep9:nettacker-scanner-add

Conversation

@securestep9
Copy link
Copy Markdown
Contributor

Proposed changes

Adding OWASP Nettacker to user agents list:
scanners-user-agents.data

See: #4528

PR Checklist

  • I have read the CONTRIBUTING doc
  • I have added positive tests proving my fix/feature works as intended.
  • I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

Further comments

OWASP Nettacker: https://github.com/OWASP/Nettacker
An example of a User-Agent header set by Nettacker is: User-Agent: Nettacker 0.4.0 QUIN

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

Adding OWASP Nettacker to user agents list:
 scanners-user-agents.data
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 7, 2026

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi changed the title Adding OWASP Nettacker to known scanners list fix: adding OWASP Nettacker to known scanners list Mar 7, 2026
Copy link
Copy Markdown
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @securestep9

@fzipi fzipi changed the title fix: adding OWASP Nettacker to known scanners list fix(913100): adding OWASP Nettacker to known scanners list Mar 7, 2026
@fzipi fzipi added this pull request to the merge queue Mar 7, 2026
Merged via the queue into coreruleset:main with commit 91397f2 Mar 7, 2026
11 of 12 checks passed
@fzipi fzipi mentioned this pull request Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants