Skip to content

fix(944110,944120,944130,944150,944151,944200,944210,..): don't inspect cookies twice#4526

Merged
EsadCetiner merged 3 commits into
coreruleset:mainfrom
touchweb-vincent:patch-15
Mar 12, 2026
Merged

fix(944110,944120,944130,944150,944151,944200,944210,..): don't inspect cookies twice#4526
EsadCetiner merged 3 commits into
coreruleset:mainfrom
touchweb-vincent:patch-15

Conversation

@touchweb-vincent
Copy link
Copy Markdown
Contributor

@touchweb-vincent touchweb-vincent commented Mar 5, 2026

Proposed changes

Hello,

Since the rule already inspects REQUEST_COOKIES, there is no need to analyze them a second time. Therefore, we exclude the Cookie header from the set of inspected headers.

Impact on rules : 944110,944120,944130,944150,944151,944200,944210,944240,944250,944260,944300,944152

PR Checklist

  • I have read the CONTRIBUTING doc
  • I have added positive tests proving my fix/feature works as intended.
  • I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

Further comments

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

…4260,944300,944152): don't inspect cookies twice
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

Comment thread rules/REQUEST-944-APPLICATION-ATTACK-JAVA.conf Outdated
@touchweb-vincent touchweb-vincent requested a review from airween March 5, 2026 20:14
@EsadCetiner EsadCetiner added this pull request to the merge queue Mar 12, 2026
Merged via the queue into coreruleset:main with commit 95354e2 Mar 12, 2026
8 checks passed
@touchweb-vincent touchweb-vincent deleted the patch-15 branch March 25, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants