Skip to content

chore: add missing regex-assembly comment blocks to rules#4523

Merged
fzipi merged 5 commits into
mainfrom
chore/add-ra-comments
Mar 5, 2026
Merged

chore: add missing regex-assembly comment blocks to rules#4523
fzipi merged 5 commits into
mainfrom
chore/add-ra-comments

Conversation

@fzipi
Copy link
Copy Markdown
Member

@fzipi fzipi commented Mar 3, 2026

what

  • add standard crs-toolchain regex update comment blocks to 15 rules that already have .ra files but were missing the comment in the conf file
  • affected rules: 921200, 932190, 932205-chain1, 932207-chain1, 932280, 932281, 932371, 933100, 933220, 934101, 934130, 941210, 941220, 952110, 953101
  • across 7 conf files

why

  • consistency: all rules with .ra files should have the standard comment pointing developers to the regex-assembly workflow

refs

@fzipi fzipi requested a review from a team March 3, 2026 23:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

fzipi
fzipi commented Mar 4, 2026
View reviewed changes
Comment thread rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf Outdated
fzipi
fzipi commented Mar 4, 2026
View reviewed changes
Comment thread rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf Outdated
fzipi
fzipi commented Mar 4, 2026
View reviewed changes
Comment thread rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf Outdated
fzipi
fzipi commented Mar 4, 2026
View reviewed changes
Comment thread rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf Outdated
Xhoenix
Xhoenix approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Xhoenix Xhoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzipi fzipi added this pull request to the merge queue Mar 5, 2026
Merged via the queue into main with commit 99b9371 Mar 5, 2026
8 checks passed
@fzipi fzipi deleted the chore/add-ra-comments branch March 5, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xhoenix Xhoenix Xhoenix approved these changes

Assignees

No one assigned

Labels

🧙 regex-assembly release:refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fzipi @Xhoenix