Skip to content

fix: don't block json variable names called profile on libmodsecurity3/coraza#4477

Merged
fzipi merged 1 commit into
coreruleset:mainfrom
EsadCetiner:fix-profile-json-fp
Feb 26, 2026
Merged

fix: don't block json variable names called profile on libmodsecurity3/coraza#4477
fzipi merged 1 commit into
coreruleset:mainfrom
EsadCetiner:fix-profile-json-fp

Conversation

@EsadCetiner
Copy link
Copy Markdown
Member

Proposed changes

When sending JSON data to libModSecurity3/Coraza, variable names are prefixed with .json. If the variable name is called profile, then that will translate to ARGS_NAMES:json.profile which matches one of the entries inside of lfi-os-files.data resulting in a false positive. This PR adds a configure-time rule exclusion to resolve this false positive.

closes: #4471

PR Checklist

  • I have read the CONTRIBUTING doc
  • I have added positive tests proving my fix/feature works as intended.
  • I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

Further comments

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

@github-actions
Copy link
Copy Markdown
Contributor

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi added this pull request to the merge queue Feb 26, 2026
Merged via the queue into coreruleset:main with commit 7b6fd84 Feb 26, 2026
8 checks passed
@EsadCetiner EsadCetiner deleted the fix-profile-json-fp branch February 28, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive for 930120 with json.profile

2 participants