fix(942200): FP against comma and single quote in French addresses#4476
Merged
Conversation
Contributor
|
📊 Quantitative test results for language: |
- Fixes FPs against French addresses, such as `999, rue d'Arlon` - Additional tests and enhanced regex Fixes coreruleset#3838 Replaces coreruleset#4236
bfd876d to
2e9569c
Compare
fzipi
reviewed
Feb 28, 2026
fzipi
approved these changes
Feb 28, 2026
airween
approved these changes
Feb 28, 2026
|
After upgrading to v4.24.0 I saw that Googlebot was being blocked by modsecurity. I believe this change is to blame, as downgrading to v4.23.0 resolves. Googlebot has the following User-Agent which is being blocked by rule 942200: |
Member
|
@mhoran Can you open an issue with your ModSecurity logs? |
theseion
added a commit
to theseion/coreruleset
that referenced
this pull request
Mar 8, 2026
Make matching of parenthesis more restrictive Refs coreruleset#4476 Fixes coreruleset#4502 Closes coreruleset#4525
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
999, rue d'ArlonFixes #4236