chore(943110): move to regex-assembly#4431
Merged
Merged
Conversation
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Contributor
|
📊 Quantitative test results for language: |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modernizes rule 943110 (Session Fixation Attack detection) by migrating it to the regex-assembly format and significantly expanding its coverage. The PR introduces a new regex-assembly file (943110.ra) with comprehensive documentation, updates the rule's regex pattern to detect session fixation attempts across many more frameworks, and adds 37 new test cases.
Changes:
- Added regex-assembly file (943110.ra) with 36+ session parameter patterns across multiple frameworks
- Updated rule 943110 regex to detect session parameters from ASP.NET, Laravel, Express.js, Flask, Django, Spring, NextAuth, Meteor, Ruby/Rails, Symfony, CakePHP, CodeIgniter, Zend, Yii, and many others
- Added 37 comprehensive test cases covering positive and negative scenarios for all major frameworks
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| regex-assembly/943110.ra | New regex-assembly file defining 36+ session parameter patterns with comprehensive documentation organized by framework/platform |
| rules/REQUEST-943-APPLICATION-ATTACK-SESSION-FIXATION.conf | Updated rule 943110 regex pattern from simple alternation to optimized regex-assembly generated pattern |
| tests/regression/tests/REQUEST-943-APPLICATION-ATTACK-SESSION-FIXATION/943110.yaml | Added 37 new test cases (tests 5-45) covering new frameworks, edge cases, and negative scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
6ee2d33 to
de2c92b
Compare
theseion
requested changes
Jan 30, 2026
fzipi
commented
Feb 1, 2026
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
for more information, see https://pre-commit.ci
Removed Flask session ID documentation from the file.
for more information, see https://pre-commit.ci
fzipi
commented
Feb 1, 2026
for more information, see https://pre-commit.ci
fzipi
commented
Feb 2, 2026
theseion
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
why