Skip to content

chore(933151,933152,933153): cleaning useless variables#4420

Merged
azurit merged 1 commit into
coreruleset:mainfrom
touchweb-vincent:patch-27
Jan 23, 2026
Merged

chore(933151,933152,933153): cleaning useless variables#4420
azurit merged 1 commit into
coreruleset:mainfrom
touchweb-vincent:patch-27

Conversation

@touchweb-vincent
Copy link
Copy Markdown
Contributor

@touchweb-vincent touchweb-vincent commented Jan 23, 2026

Proposed changes

Hello, these variables are no longer useful either in the current state of the new rules.

PR Checklist

  • [x ] I have read the CONTRIBUTING doc
  • I have added positive tests proving my fix/feature works as intended.
  • I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

Further comments

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 23, 2026

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

fzipi
fzipi approved these changes Jan 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azurit azurit added this pull request to the merge queue Jan 23, 2026
Merged via the queue into coreruleset:main with commit c85344c Jan 23, 2026
8 checks passed
@touchweb-vincent touchweb-vincent deleted the patch-27 branch January 23, 2026 16:09
@theseion theseion mentioned this pull request Feb 2, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azurit azurit azurit approved these changes

@fzipi fzipi fzipi approved these changes

Assignees

No one assigned

Labels

🧹 cleanup House cleaning release:fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@touchweb-vincent @azurit @fzipi