Skip to content

chore(941360,941370,941380): cleaning useless capture keyword#4419

Merged
fzipi merged 1 commit into
coreruleset:mainfrom
touchweb-vincent:patch-25
Jan 23, 2026
Merged

chore(941360,941370,941380): cleaning useless capture keyword#4419
fzipi merged 1 commit into
coreruleset:mainfrom
touchweb-vincent:patch-25

Conversation

@touchweb-vincent
Copy link
Copy Markdown
Contributor

Proposed changes

Hello, since the capture keyword is only useful when not using %{TX.X} variables, I propose removing them. If I have the time and motivation, I’ll review the other rule sets as well.

PR Checklist

  • [ x] I have read the CONTRIBUTING doc
  • I have added positive tests proving my fix/feature works as intended.
  • I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

Further comments

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

Removed 'capture' action from multiple security rules to streamline processing.
@github-actions
Copy link
Copy Markdown
Contributor

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi
Copy link
Copy Markdown
Member

fzipi commented Jan 23, 2026

I have still to push a check for this in the linter (coreruleset/crs-linter#87)

@fzipi fzipi added this pull request to the merge queue Jan 23, 2026
Merged via the queue into coreruleset:main with commit ada134e Jan 23, 2026
8 checks passed
@touchweb-vincent touchweb-vincent deleted the patch-25 branch January 23, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants