Skip to content

chore(933120): cleaning obsolete variable#4417

Merged
fzipi merged 1 commit into
coreruleset:mainfrom
touchweb-vincent:patch-26
Jan 22, 2026
Merged

chore(933120): cleaning obsolete variable#4417
fzipi merged 1 commit into
coreruleset:mainfrom
touchweb-vincent:patch-26

Conversation

@touchweb-vincent
Copy link
Copy Markdown
Contributor

@touchweb-vincent touchweb-vincent commented Jan 22, 2026

Proposed changes

Hello, these assignments are a legacy from CRS 3, when the rule used a chained structure, which is no longer the case. There is therefore no longer any reason to keep these variable assignments to preserve the mappings from the first link in the chain.

PR Checklist

  • [ X] I have read the CONTRIBUTING doc
  • I have added positive tests proving my fix/feature works as intended.
  • I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

Further comments

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

@github-actions
Copy link
Copy Markdown
Contributor

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@touchweb-vincent touchweb-vincent changed the title chore(932120): cleaning obsolete variable chore(933120): cleaning obsolete variable Jan 22, 2026
Copy link
Copy Markdown
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think this was from a1326e1, not from v3.

@fzipi fzipi added this pull request to the merge queue Jan 22, 2026
Merged via the queue into coreruleset:main with commit 78be9e0 Jan 22, 2026
16 checks passed
@touchweb-vincent touchweb-vincent deleted the patch-26 branch January 23, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants