fix(933111): regex should be the same as 933110#4395
Conversation
|
📊 Quantitative test results for language: |
Added additional test cases for PHP injection attack scenarios.
|
@touchweb-vincent Can you re-do this PR? Something is messed up with it, see bottom of the |
|
Hm, wait with that, maybe the problem is somewhere else. |
|
@azurit i think, all recent PR got this problem. |
|
Yes, problem seems to be on our side. |
fzipi
left a comment
There was a problem hiding this comment.
Makes sense, thanks for catching this one.
Probably would make even more sense moving the regexp to an include and then including it from both rules so it doesn't happen again.
Do you want to follow up with this @touchweb-vincent?
|
@fzipi Thanks. I've added it to me TODO https://docs.google.com/spreadsheets/d/1DjswZCYaMrAOHMZOASof7kOZAlOzUaBOTUN9wzXL1aA/edit |
Hello,
Since this regex is intended to be a stricter sibling of 933110, we should reuse the same regex.
What do you think ?
Vincent