Skip to content

feat(934100): added sequence for CVE-2025-55182 POCs#4372

Merged
EsadCetiner merged 11 commits into
coreruleset:mainfrom
touchweb-vincent:patch-23
Dec 7, 2025
Merged

feat(934100): added sequence for CVE-2025-55182 POCs#4372
EsadCetiner merged 11 commits into
coreruleset:mainfrom
touchweb-vincent:patch-23

Conversation

@touchweb-vincent
Copy link
Copy Markdown
Contributor

@touchweb-vincent touchweb-vincent commented Dec 6, 2025

Hello,

Here is a proposal to address some POCs seen by @RedXanadu and shared on the Slack.

This should improve (a bit) the CRS coverage for CVE-2025-55182 on PL1

For console.log, we have an existing ra block for console. but i failed to understand how add log on console-funcs variable Already caught by 941390

What do you think ?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 6, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@dune73
Copy link
Copy Markdown
Member

dune73 commented Dec 6, 2025

Thank you @touchweb-vincent. This looks good.

Are there situations where console.log could be used in standard (development) situations?

I'd say yes, but it's much more likely an information leakage we want to avoid. But let's have the conversation on record.

@touchweb-vincent
Copy link
Copy Markdown
Contributor Author

touchweb-vincent commented Dec 6, 2025

@dune73 Maybe, I don’t know the NodeJS ecosystem very well, but it's already caught by 941390 - I hadn’t checked before. So I removed it.

curl -H "x-format-output: txt-matched-rules" -H "x-crs-paranoia-level:4" "http://sandbox.coreruleset.org/" -d 'test=console.log(1);'
941390 PL1 Javascript method detected

Copy link
Copy Markdown
Member

@EsadCetiner EsadCetiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to merge

Can you add the non-encoded payloads within the test description?

I think it's fine to detect console.log even though it's not particularly harmful, it shouldn't cause false positives anyways since it's a very specific string. It's still a general indicator of attack.

@touchweb-vincent
Copy link
Copy Markdown
Contributor Author

Done @EsadCetiner - in a comment like this one:
https://github.com/coreruleset/coreruleset/blob/main/tests/regression/tests/REQUEST-941-APPLICATION-ATTACK-XSS/941380.yaml

console.log is already covered by 941390. Do you still want to catch it in 934100?
If yes, could you please explain how to override the console-funcs variable from the RA file?
https://github.com/coreruleset/coreruleset/blob/main/regex-assembly/934100.ra#L183

@EsadCetiner
Copy link
Copy Markdown
Member

@touchweb-vincent Sorry, I'm not sure what change your exactly trying to make. What's wrong with just adding console.log like in your earlier commit?

@touchweb-vincent
Copy link
Copy Markdown
Contributor Author

Following our discussion on Slack, it's done. Thanks for the help.

@EsadCetiner EsadCetiner added this pull request to the merge queue Dec 7, 2025
Merged via the queue into coreruleset:main with commit eea3e85 Dec 7, 2025
8 checks passed
@touchweb-vincent touchweb-vincent deleted the patch-23 branch December 7, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants