Skip to content

feat(942460): adding help for non-English folks#4334

Merged
theseion merged 6 commits into
coreruleset:mainfrom
touchweb-vincent:patch-18
Nov 14, 2025
Merged

feat(942460): adding help for non-English folks#4334
theseion merged 6 commits into
coreruleset:mainfrom
touchweb-vincent:patch-18

Conversation

@touchweb-vincent
Copy link
Copy Markdown
Contributor

Hello,

A little thought for our non-English folks would be welcome.

What do you think ?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 12, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

Comment thread rules/REQUEST-942-APPLICATION-ATTACK-SQLI.conf Outdated
Comment thread rules/REQUEST-942-APPLICATION-ATTACK-SQLI.conf Outdated
touchweb-vincent and others added 3 commits November 14, 2025 06:16
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
@theseion theseion added this pull request to the merge queue Nov 14, 2025
Merged via the queue into coreruleset:main with commit 18ea9d3 Nov 14, 2025
7 checks passed
@theseion
Copy link
Copy Markdown
Contributor

Thanks @touchweb-vincent. While I think it's good to have comments like this, the comment is buried in the rules and nobody will find it. I think it would help if we started a section in the documentation, where we list rules such as this one with their explanation. Basically, a place where we can tell users to watch out for certain rules. Would you like to create such a section in the docs?

@touchweb-vincent
Copy link
Copy Markdown
Contributor Author

@theseion I’ll answer you the same way I did here: : #4293 (comment)

It’s certain that the - very rare - folks who work with and want to work on PL3 will read the comments.

That said, there’s nothing stopping us from discussing it elsewhere as well.

@touchweb-vincent touchweb-vincent deleted the patch-18 branch November 14, 2025 10:48
@theseion
Copy link
Copy Markdown
Contributor

That is probably true.

@fzipi fzipi mentioned this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants