fix(942160): adding unit test for double comment#4315
Merged
Conversation
EsadCetiner
requested changes
Nov 3, 2025
Member
EsadCetiner
left a comment
There was a problem hiding this comment.
Makes sense, doesn't hurt to add a extra test for this case.
…160.yaml Co-authored-by: Esad Cetiner <104706115+EsadCetiner@users.noreply.github.com>
EsadCetiner
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
There is very likely a unit test on mod_security2 itself to ensure that the t:replaceComments transformation is resilient to bypass attempts, but I think it’s missing one specifically for this rule.
I would understand if you don’t find it useful.