Skip to content

fix(942431): reduce false positive with arrays in ARGS_NAMES #4305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EsadCetiner merged 16 commits into from
Dec 9, 2025
+36 −2
Merged

fix(942431): reduce false positive with arrays in ARGS_NAMES #4305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4f7c3cb
fix(942431): reduce false positive in backoffice
touchweb-vincent Oct 22, 2025
d848f8d
Update 942431.yaml
touchweb-vincent Oct 22, 2025
ed085bd
Update 942431.yaml
touchweb-vincent Oct 22, 2025
ad11787
Update REQUEST-942-APPLICATION-ATTACK-SQLI.conf
touchweb-vincent Oct 23, 2025
59b2746
Update REQUEST-942-APPLICATION-ATTACK-SQLI.conf
touchweb-vincent Oct 23, 2025
7b7d457
Update 942431.yaml
touchweb-vincent Oct 23, 2025
ced10f2
Merge branch 'main' into patch-8
EsadCetiner Oct 25, 2025
f58f9f3
Update lint.yaml
touchweb-vincent Oct 25, 2025
de13710
Merge branch 'main' into patch-8
touchweb-vincent Nov 25, 2025
2b16ee9
Merge branch 'main' into patch-8
touchweb-vincent Dec 7, 2025
f7abf8a
Update rules/REQUEST-942-APPLICATION-ATTACK-SQLI.conf
touchweb-vincent Dec 8, 2025
a672e72
Update REQUEST-942-APPLICATION-ATTACK-SQLI.conf
touchweb-vincent Dec 8, 2025
41477d6
Merge branch 'main' into patch-8
touchweb-vincent Dec 8, 2025
51a43cd
Update REQUEST-942-APPLICATION-ATTACK-SQLI.conf
touchweb-vincent Dec 8, 2025
6c007a9
Update REQUEST-942-APPLICATION-ATTACK-SQLI.conf
touchweb-vincent Dec 8, 2025
83fe317
Update REQUEST-942-APPLICATION-ATTACK-SQLI.conf
touchweb-vincent Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/REQUEST-942-APPLICATION-ATTACK-SQLI.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1784,7 +1784,7 @@ SecRule REQUEST_COOKIES|!REQUEST_COOKIES:/_pk_ref/|REQUEST_COOKIES_NAMES "@rx ((
# [ SAP CRM Java vulnerability CVE-2018-2380 - Exploit tested: https://www.exploit-db.com/exploits/44292 ]
#

SecRule ARGS_NAMES|ARGS|XML:/* "@rx ((?:[~!@#\$%\^&\*\(\)\-\+=\{\}\[\]\|:;\"'´’‘`<>][^~!@#\$%\^&\*\(\)\-\+=\{\}\[\]\|:;\"'´’‘`<>]*?){6})" \
SecRule ARGS_NAMES|!ARGS_NAMES:/^[\w]+\[[\w\-]+\]\[[\w\-]*?\]$/|!ARGS_NAMES:/^[\w]+\[[\w\-]+\]\[[\w\-]+\]\[[\w\-]*?\]$/|ARGS|XML:/* "@rx ((?:[~!@#\$%\^&\*\(\)\-\+=\{\}\[\]\|:;\"'´’‘`<>][^~!@#\$%\^&\*\(\)\-\+=\{\}\[\]\|:;\"'´’‘`<>]*?){6})" \
"id:942431,\
phase:2,\
block,\
Expand Down
36 changes: 35 additions & 1 deletion tests/regression/tests/REQUEST-942-APPLICATION-ATTACK-SQLI/942431.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
meta:
author: "Christian S.J. Peron, azurit"
author: "Christian S.J. Peron, azurit, touchweb_vincent"
rule_id: 942431
tests:
- test_id: 1
Expand All @@ -20,3 +20,37 @@ tests:
output:
log:
expect_ids: [942431]
- test_id: 2
desc: "Avoid blocking on three-dimensional arrays"
stages:
- input:
dest_addr: 127.0.0.1
headers:
Host: localhost
User-Agent: "OWASP CRS test agent"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
method: POST
port: 80
uri: "/post"
data: "order[filters][date_add][from]=1"
version: HTTP/1.1
output:
log:
no_expect_ids: [942431]
- test_id: 3
desc: "Avoid blocking on bi-dimensional arrays"
stages:
- input:
dest_addr: 127.0.0.1
headers:
Host: localhost
User-Agent: "OWASP CRS test agent"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
method: POST
port: 80
uri: "/post"
data: "order[add-to-cart][]=1"
version: HTTP/1.1
output:
log:
no_expect_ids: [942431]
Loading