feat(930120): adding conf file for PrestaShop 1.6 / 1.7 / 8+ & Magento 2#4303
Conversation
|
📊 Quantitative test results for language: |
EsadCetiner
left a comment
There was a problem hiding this comment.
I just noticed you didn't add these 3 entries to restricted-files.dataandrestricted-upload.data, can you update those data files too?
|
Hello, Done |
|
I don't understand why 959100-3 is failling : https://github.com/touchweb-vincent/coreruleset/blob/patch-3/tests/regression/tests/RESPONSE-959-BLOCKING-EVALUATION/959100.yaml#L52 |
|
Interesting, I think there's a race condition with our CI pipeline, that change shouldn't have caused @theseion Can you take a look at what might've caused this: https://github.com/coreruleset/coreruleset/actions/runs/18737486580/job/53447100629#step:4:379 |
EsadCetiner
left a comment
There was a problem hiding this comment.
Can you add config/parameters.php to the other config files as well? You should be able to remove config/settings.inc.php as it's covered by our detection for generic config file names.
|
There's nothing we can do about that, unfortunately. Parsing logs is inherently brittle and we already try very hard to force the web server to flush the log before we try to read it. We're actually pretty lucky that we see these issues only a handful of times per year. |
|
config/settings.inc.php is not covered : curl -H "x-format-output: txt-matched-rules" -H "x-crs-paranoia-level:4" "https://sandbox.coreruleset.org/?test=/config/settings.inc.php" Where do you want me to add config/parameters.php ? |
|
@touchweb-vincent Sorry, I meant the data files. These should be added to
Yes your right, I missed that. |
|
I didn't add them in restricted-upload.data because there are already present : config/parameters.php : coreruleset/rules/restricted-files.data Line 335 in ae25972 config/settings.inc.php : coreruleset/rules/restricted-files.data Line 334 in ae25972 |
|
That's |
|
Same here : parameters.php : coreruleset/rules/restricted-upload.data Line 345 in ae25972 settings.inc.php : coreruleset/rules/restricted-upload.data Line 361 in ae25972 |
Hello,
Quick add