Fix for Heading without space after # #70
Fix for Heading without space after # #70codesForLiving wants to merge 1 commit intocommonmark:masterfrom
Conversation
|
Closing as tests were not updated |
|
Looked at the code anyway :). So just a heads-up: The reason it requires a space is so that it conforms to the commonmark spec:
So I wouldn't merge a pull request that makes the space optional in all cases. Maybe it could be an option on the parser, but I'm also not sure if that's a good thing to do, I don't want to provide too many non-spec-compliant options either. |
From : commnmark spec page:
It seems like a good enough reason to provide it as option. :) |
|
The "many implementations" in that sentence refers to other Markdown implementations as opposed to CommonMark, see other uses of "implementations" in the spec. Could you explain what your use case is for which you need this? |
|
I need it to parse data from Reddit. |
#HeadingIs not parsed as heading now. Space or tab is needed after #