Skip to content

test: add cases for BodyValidator leading blank line edge cases #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 2 commits into from
Jul 31, 2026
Merged

test: add cases for BodyValidator leading blank line edge cases #492

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4feabe4
test: add coverage for BodyValidator leading blank line edge cases
RubenSanosh Jul 30, 2026
cd4a018
ci: auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions tests/engine_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,6 +968,50 @@ def test_validate_without_body(self):
result = validator.validate(context)
assert result == ValidationResult.FAIL

@pytest.mark.benchmark
def test_validate_with_leading_blank_lines_and_body(self):
"""Test body validation with leading blank lines before body content.

_get_commit_message() strips input before BodyValidator sees it, so
leading blank lines are removed and this collapses to a single line
with no separate subject/body it should FAIL.
"""
rule = ValidationRule(check="require_body")
validator = BodyValidator(rule)
context = ValidationContext(stdin_text="\n\nbody content")

with patch("commit_check.util._print_failure"):
result = validator.validate(context)
assert result == ValidationResult.FAIL

@pytest.mark.benchmark
def test_validate_with_leading_blank_lines_no_body(self):
"""Test body validation with only leading blank lines and no content.

After stripping, this becomes an empty message, which is treated as
having no commit message at all — it should PASS.
"""
rule = ValidationRule(check="require_body")
validator = BodyValidator(rule)
context = ValidationContext(stdin_text="\n\n")

result = validator.validate(context)
assert result == ValidationResult.PASS

@pytest.mark.benchmark
def test_validate_with_whitespace_only_message(self):
"""Test body validation with a whitespace-only message.

After stripping, this becomes an empty message, same as the
leading-blank-lines-only case — it should PASS.
"""
rule = ValidationRule(check="require_body")
validator = BodyValidator(rule)
context = ValidationContext(stdin_text=" \n ")

result = validator.validate(context)
assert result == ValidationResult.PASS


class TestMergeBaseValidator:
@patch("commit_check.util.git_merge_base")
Expand Down
Loading