Skip to content

chore: remove dead else branch in print_suggestion() #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 2 commits into from
Jul 30, 2026
Merged

chore: remove dead else branch in print_suggestion() #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
298e9ae
fix: remove dead else branch in print_suggestion() (#486)
XEDAB Jul 29, 2026
75032a3
fix: resolve mypy type error in print_suggestion call
XEDAB Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions commit_check/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def _print_failure(
print_error_header()
print_error_message(check["check"], check.get("error", ""), actual)
if check.get("suggest"):
print_suggestion(check.get("suggest"))
print_suggestion(check["suggest"])


def get_branch_name() -> str:
Expand Down Expand Up @@ -301,7 +301,7 @@ def print_error_message(check_type: str, error: str, reason: str):
print(error)


def print_suggestion(suggest: str | None) -> None:
def print_suggestion(suggest: str) -> None:
"""Print suggestion to user
:param suggest: what message to print out
"""
Expand All @@ -310,7 +310,4 @@ def print_suggestion(suggest: str | None) -> None:
f"Suggest: {GREEN}{suggest}{RESET_COLOR} ",
end="",
)
else:
print(f"commit-check does not support {suggest} yet.")
raise SystemExit(1)
print("\n")
9 changes: 0 additions & 9 deletions tests/util_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,15 +605,6 @@ def test_print_suggestion(self, capfd):
stdout, _ = capfd.readouterr()
assert "Suggest:" in stdout

@pytest.mark.benchmark
def test_print_suggestion_exit1(self, capfd):
# Must exit with 1 when "" passed
with pytest.raises(SystemExit) as e:
print_suggestion("")
assert e.value.code == 1
stdout, _ = capfd.readouterr()
assert "commit-check does not support" in stdout


class TestGetGitConfigValue:
"""Tests for get_git_config_value utility function."""
Expand Down