Skip to content

test: mock git config in signoff ignore-author test #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 1 commit into from
Jul 25, 2026
+7 −1
Merged

test: mock git config in signoff ignore-author test #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/engine_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,16 +821,22 @@ def test_default_signoff_rejects_missing_signoff(self):
result = validator.validate(context)
assert result == ValidationResult.FAIL

@patch(GIT_CONFIG_VALUE)
@patch("commit_check.engine.get_commit_info")
@pytest.mark.benchmark
def test_default_signoff_skips_ignored_author(self, mock_get_commit_info):
def test_default_signoff_skips_ignored_author(
self, mock_get_commit_info, mock_get_git_config_value
):
"""Signoff check is skipped when the author is in ignore_authors.

A commit with no signoff would normally fail, but an ignored author
(e.g. a bot) should bypass the signoff check just like every other
commit check.
"""
mock_get_commit_info.return_value = "dependabot[bot]"
# Mock git config so author resolution falls back to the commit author
# instead of the developer's real local user.name.
mock_get_git_config_value.return_value = ""
validator = SignoffValidator(self._default_signoff_rule())
config = {"commit": {"ignore_authors": ["dependabot[bot]"]}}
context = ValidationContext(stdin_text="chore: bump dep", config=config)
Expand Down