fix: skip signoff check for ignored authors - #464
Conversation
SignoffValidator used the base skip helper, so it was the only commit-level check that did not honor ignore_authors — a bot in the ignore list still had its signoff validated. Use _should_skip_commit_validation so signoff is skipped for ignored authors, consistent with the message, author, and body checks. Add a test covering the skip behavior.
✅ Deploy Preview for commit-check ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
+ Coverage 97.02% 97.10% +0.08%
==========================================
Files 12 12
Lines 1176 1176
==========================================
+ Hits 1141 1142 +1
+ Misses 35 34 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 91.46%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_empty_message_passes |
1,433.6 µs | 748.8 µs | +91.46% |
| 🆕 | test_default_signoff_skips_ignored_author |
N/A | 682.9 µs | N/A |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bugfix/signoff-respect-ignore-authors (92fc09b) with main (df32a83)
Footnotes
-
109 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
SignoffValidator used the base skip helper, so it was the only commit-level check that did not honor ignore_authors — a bot in the ignore list still had its signoff validated. Use _should_skip_commit_validation so signoff is skipped for ignored authors, consistent with the message, author, and body checks. Add a test covering the skip behavior.