Skip to content

fix(require_signed_off_by): allow any name - #462

Merged
shenxianpeng merged 1 commit into
commit-check:mainfrom
StaticRocket:bugfix/require_signed_off_by
Jul 9, 2026
Merged

fix(require_signed_off_by): allow any name#462
shenxianpeng merged 1 commit into
commit-check:mainfrom
StaticRocket:bugfix/require_signed_off_by

Conversation

@StaticRocket

@StaticRocket StaticRocket commented Jul 9, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

This regex is too strict right now. Same could probably be said about the author_name regex. It catches bots like dependabot incorrectly.

Dependabot uses the following sign off trailer:

Signed-off-by: dependabot[bot] <support@github.com>

Summary by CodeRabbit

  • Bug Fixes
    • Tightened commit sign-off validation so only properly formatted Signed-off-by entries are accepted.
    • Improved consistency in commit checks by reducing false positives from loosely formatted sign-off lines.

@StaticRocket
fix(require_signed_off_by): allow any name
cb59f17 
This regex is too strict right now. Same could probably be said about
the author_name regex. It catches bots like dependabot incorrectly.

Signed-off-by: Randolph Sapp <rs@ti.com>
@StaticRocket
StaticRocket requested a review from a team as a code owner July 9, 2026 01:30
@StaticRocket
StaticRocket requested review from shenxianpeng and removed request for a team July 9, 2026 01:30
@netlify

netlify Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for commit-check ready!

Name Link
🔨 Latest commit cb59f17
🔍 Latest deploy log https://app.netlify.com/projects/commit-check/deploys/6a4ef9bf55fcc000081e2516
😎 Deploy Preview https://deploy-preview-462--commit-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9075907f-3487-4cf7-9bed-e3f19f7918fc

📥 Commits

Reviewing files that changed from the base of the PR and between d10f1f9 and cb59f17.

📒 Files selected for processing (1)
  • commit_check/rules_catalog.py
📝 Walkthrough

Walkthrough

The regex pattern for the require_signed_off_by rule in the commit-check rules catalog is changed from a permissive pattern to a stricter one, narrowing what commit trailers satisfy the Signed-off-by validation check.

Changes

Signed-off-by Regex Update

Layer / File(s) Summary
Tighten Signed-off-by regex pattern
commit_check/rules_catalog.py		 The require_signed_off_by rule's regex changes from Signed-off-by:.*[A-Za-z0-9]\s+<.+@.+> to Signed-off-by: .+ <.+@.+>, requiring stricter formatting to pass validation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: loosening require_signed_off_by validation to allow any name.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codspeed-hq

codspeed-hq Bot commented Jul 9, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 358 untouched benchmarks
⏩ 109 skipped benchmarks1

Comparing StaticRocket:bugfix/require_signed_off_by (cb59f17) with main (0b255d0)2

Open in CodSpeed

Footnotes

  1. 109 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (d10f1f9) during the generation of this report, so 0b255d0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@StaticRocket StaticRocket mentioned this pull request Jul 9, 2026
Merged
shenxianpeng
shenxianpeng approved these changes Jul 9, 2026
View reviewed changes

@shenxianpeng shenxianpeng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

@codecov

codecov Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.10%. Comparing base (d10f1f9) to head (cb59f17).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   97.19%   97.10%   -0.09%     
==========================================
  Files          12       12              
  Lines        1176     1176              
==========================================
- Hits         1143     1142       -1     
- Misses         33       34       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shenxianpeng shenxianpeng added the bug Something isn't working label Jul 9, 2026
@shenxianpeng
shenxianpeng merged commit 092a824 into commit-check:main Jul 9, 2026
30 of 32 checks passed
@shenxianpeng shenxianpeng mentioned this pull request Jul 9, 2026
Merged
@StaticRocket

StaticRocket commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the quick turnaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shenxianpeng shenxianpeng shenxianpeng approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StaticRocket @shenxianpeng