fix: only look at .gitignores from within the current repository - #49
Merged
Merged
Conversation
laukondrup
commented
Sep 16, 2025
Comment on lines
+304
to
+308
| expect(filesList.sort()).toMatchObject( | ||
| [`${root}/project/packageA/src/fileE.json`] | ||
| .sort() | ||
| .map(toPlatformSpecificPath), | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Currently, this returns an empty array because the implementation will look at the .gitignore on line 282
laukondrup
commented
Sep 16, 2025
laukondrup
force-pushed
the
laukondrup/support-meta-repo
branch
from
September 16, 2025 20:11
9c89cbe to
9e39753
Compare
laukondrup
force-pushed
the
laukondrup/support-meta-repo
branch
from
September 19, 2025 10:51
b89a8d2 to
f2de031
Compare
laukondrup
commented
Sep 19, 2025
| searchRoot: string | ||
| fsRoot: string | ||
| }) => { | ||
| let currentDir = path.resolve(searchRoot) |
Contributor
Author
There was a problem hiding this comment.
Not sure if the code should be defensive - if the user passes a path that doesn't exist this will throw an error
laukondrup
marked this pull request as ready for review
September 19, 2025 10:54
Contributor
|
@laukondrup It has been released in version 0.36.0. Thank you for your contribution ! |
Contributor
Author
|
Cheers 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #48