New Analyzer CC0125 - getter only auto property#904
Merged
carloscds merged 10 commits intocode-cracker:masterfrom May 3, 2017
Merged
New Analyzer CC0125 - getter only auto property#904carloscds merged 10 commits intocode-cracker:masterfrom
carloscds merged 10 commits intocode-cracker:masterfrom
Conversation
…de not found in tree) for certain symbols.
Contributor
Author
|
@carloscds The last commit (fa20c95) only added one line of code to prevent an ArgumentException and to increase performance. |
Contributor
Author
|
@carloscds I pushed another small change related to the previous bug. The cause of the bug is now covert by unit tests. The fixer does not rename fields in partial classes causing a CS0103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #881.
New analyzer CC0125 - getter only auto property.
Port from https://github.com/ifpanalytics/Ifp.Analyzers.
Remaining issues:
WellKnownFixAllProviders.BatchFixer. TheBatchFixeris not able to fix multiple properties in a class at once (fixes about every second property in a class at once). There are not tests covering theFixAllProvider.Let me know if any of these issues are show-stoppers and I will look into it.
I also prepared the documentation for the analyzer at code-cracker/code-cracker.github.io@master...MaStr11:DocsForCC0125.
I can create a pull request as needed.