Skip to content

Add string interpolation to Console.WriteLine#388

Merged
carloscds merged 1 commit intocode-cracker:masterfrom
giggio:console-writeline-interpolation
Jun 24, 2015
Merged

Add string interpolation to Console.WriteLine#388
carloscds merged 1 commit intocode-cracker:masterfrom
giggio:console-writeline-interpolation

Conversation

@giggio
Copy link
Copy Markdown
Member

@giggio giggio commented Jun 19, 2015

Closes #380
Already using localization
Updated String.Format analyzer and code fix to use localization
and to the more performant code action.
Using common code for string.format and console.writeline.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argumentList.Arguments.Skip(1).Any(a => context.SemanticModel.GetTypeInfo(a.Expression).Type.TypeKind == TypeKind.Array) can be computed once

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baks what do you mean? It is being computed once.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giggio, my mistake

@giggio giggio force-pushed the console-writeline-interpolation branch 2 times, most recently from 07bfc2c to 1b5ce3b Compare June 21, 2015 02:02
@carloscds carloscds self-assigned this Jun 21, 2015
@giggio giggio force-pushed the console-writeline-interpolation branch from 1b5ce3b to 8587b27 Compare June 24, 2015 01:52
Closes code-cracker#380
Already using localization
Updated String.Format analyzer and code fix to use localization
and to the more performant code action.
Using common code for string.format and console.writeline.
@giggio giggio force-pushed the console-writeline-interpolation branch from 8587b27 to 21bb585 Compare June 24, 2015 01:52
carloscds pushed a commit that referenced this pull request Jun 24, 2015
Add string interpolation to Console.WriteLine
@carloscds carloscds merged commit cc44ad2 into code-cracker:master Jun 24, 2015
@giggio giggio deleted the console-writeline-interpolation branch June 24, 2015 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add string interpolation to Console.WriteLine

3 participants