Skip to content

Make method static#376

Merged
carloscds merged 1 commit intocode-cracker:masterfrom
giggio:static-method
Jun 21, 2015
Merged

Make method static#376
carloscds merged 1 commit intocode-cracker:masterfrom
giggio:static-method

Conversation

@giggio
Copy link
Copy Markdown
Member

@giggio giggio commented Jun 12, 2015

closes #364

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The analyzer should also immediately return if there are any of this method modifiers:

  • virtual
  • override
  • new
  • partial

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baks makes sense. I will updated it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baks Done. Also added abstract.

@carloscds
Copy link
Copy Markdown

@giggio Giovanni, can you update your PR for merge ?

@giggio
Copy link
Copy Markdown
Member Author

giggio commented Jun 20, 2015

@carloscds done!

carloscds pushed a commit that referenced this pull request Jun 21, 2015
@carloscds carloscds merged commit 45c9d56 into code-cracker:master Jun 21, 2015
@giggio giggio deleted the static-method branch June 21, 2015 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make method static if possible

3 participants