Remove unused parameters: analyzer and fix#207
Remove unused parameters: analyzer and fix#207carloscds merged 2 commits intocode-cracker:masterfrom
Conversation
|
Looks good! |
|
@viniciushana Are you working in this PR ? |
|
Not really, just did a quick glance over the changes. |
|
ok. I will go analyze it. |
|
@giggio If I have a call to method that has unused parameter and I apply this, my code broken: static void Main(string[] args)
{
foo(10, 20);
}
public static void foo(int a, int b)
{
int c = a;
}become this: static void Main(string[] args)
{
foo(10, 20); // error here
}
public static void foo(int a)
{
int c = a;
}Do you expect to check this ? |
|
And then again we reach a point where we need to fix references done throughout the whole codebase :( |
|
@carloscds another one of those problems of referenced code, that may be anywhere on the solution. Good catch, Carlos! But I don't know what to do... I think, from what we discussed earlier this week on our meeting, that we can make the change and let it break, but I am not sure... what do you think? @viniciushana @ElemarJR what do you think? |
|
@giggio It´s same case of privateset, maybe change to hidden and not warning. |
|
@carloscds I think I found a solution. As we are going to remove the parameter, I can do that on the code fix, and that can be async. Hold on, I will fix it, I will send an update. |
2bc5c64 to
33ec88a
Compare
|
@carloscds this was fixed. Reference is now updated. Beautiful! 🚴 |
|
@giggio Cool. |
|
@giggio Can I merge it ? |
|
@carloscds Yes, you can |
Remove unused parameters: analyzer and fix
Fixes #24.