Skip to content

Add Safari 10 to browserslist - #435

Merged
spaceninja merged 2 commits into
masterfrom
fix/add-safari-10-to-browserslist
Mar 2, 2020
Merged

Add Safari 10 to browserslist#435
spaceninja merged 2 commits into
masterfrom
fix/add-safari-10-to-browserslist

Conversation

@calebeby

Copy link
Copy Markdown
Member

If we are going to have workarounds to support Safari 10, we should also ensure that autoprefixer generates prefixes compatible with Safari 10 and that postcss-preset-env emits syntax compatible with Safari 10

@calebeby
calebeby requested a review from tylersticka July 19, 2018 17:31
Comment thread browserslist Outdated

> 4%
Last 1 version
Safari 10

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any benefit to making this Safari > 9 or similar, to prevent any future weird "gaps" where fixes are included for Safari 10 but not 11?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would Last 3 Safari versions do what we want it to?

Safari 11.1
Safari 11
Safari 10.1

Then it would require less maintenance, because it would automatically update when new versions are released.

Another thing that might be worth looking into is browserslist-ga. What do you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have a strong opinion on how it's done as long as the version gap problem is solved.

@tylersticka tylersticka added the 🗿 legacy Applies to pre-2020 project label Feb 19, 2020
@spaceninja

spaceninja commented Mar 2, 2020

Copy link
Copy Markdown
Member

@tylersticka I updated to Last 3 Safari versions — any objects to approving this so I can clear the decks?

@spaceninja
spaceninja merged commit ceac269 into master Mar 2, 2020
@spaceninja
spaceninja deleted the fix/add-safari-10-to-browserslist branch March 2, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗿 legacy Applies to pre-2020 project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants