Added hooks for Appdynamics support#103
Added hooks for Appdynamics support#103pavankrish123 wants to merge 1 commit intocloudfoundry:developfrom
Conversation
|
Hey pavankrish123! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/156791846 The labels on this github issue will be updated when the story is started. |
|
publicized membership to appdynamics org covered under a Corporate CLA. |
|
Hey pavankrish123! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/156813786 The labels on this github issue will be updated when the story is started. |
|
Hello @sclevine - Can you please confirm if we are all set with the pull request. I have closed and reopened the PR after I have publicized my Appdynamics org membership? Just making sure everything is taken care of from my end. Thanks |
|
Sorry for the delay! Looks great to me. Prioritizing for team review. |
|
Hello @sclevine. Any rough estimate on when the review will be done and the hooks will be merged ? |
|
Merged this in manually |
Thanks for contributing to the buildpack. To speed up the process of reviewing your pull request please provide us with:
Submitted on behalf of Appdynamics Organization.
Added hooks to support Appdynamics integration.
The changes in this PR enables python applications to integrate with appdynamics for application performance and instrumentation with the help of appdynamics service broker
If the application is bound to appdynamics service(VCAP_SERVICE), these changes installs necessary appdynamics packages, writes environment variables to the application process to connect to appdynamics controller.
The procedure above is similar to appdynamics support present in all the other language buildpacks
e.g.. cloudfoundry/nodejs-buildpack cloudfoundry/java-buildpack
Added test cases (100% code coverage), both unit and integration.
Submitted on behalf of Appdynamics organization. Believe we already have CLA signed for other cloudfoundry buildpacks (nodejs and Java). So I am assuming it is signed and is redundant. If not, kindly let me know, I will have it signed by our PM and get it to you
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have added an integration test