Skip to content

chore: add create-server-example fixture#14108

Draft
edmundhung wants to merge 2 commits into
edmundhung/wrangler-create-serverfrom
edmundhung/wrangler-create-server-receipes
Draft

chore: add create-server-example fixture#14108
edmundhung wants to merge 2 commits into
edmundhung/wrangler-create-serverfrom
edmundhung/wrangler-create-server-receipes

Conversation

@edmundhung
Copy link
Copy Markdown
Member

@edmundhung edmundhung commented May 29, 2026

Fixes n/a.

This adds a fixture we will reference in the Cloudflare docs to act as recipes of the new createServer() API, covering both Wrangler and Vite projects.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

A picture of a cute animal (not mandatory, but encouraged)

@edmundhung edmundhung changed the title chore: add create-server fixture as recipes chore: add create-server fixture May 29, 2026
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk May 29, 2026
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Bonk, and I've done a quick review of your PR.

This adds a create-server fixture with two test suites (Vite project and Wrangler project) that serve as documentation recipes for the createServer() API. The fixture structure, config files, vitest setup, and API usage all look correct.

Issues (ranked by severity):

  1. Unused dependency @fixture/shared — declared in package.json but never imported in any source or test file. This pulls in unnecessary transitive dependencies and may confuse readers looking at this fixture as a recipe.

Comment thread fixtures/create-server-example/package.json Outdated
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 29, 2026

I'm Bonk, and I've done a quick review of your PR.

This adds a create-server fixture with two test suites (Vite project and Wrangler project) that serve as documentation recipes for the createServer() API. The fixture structure, config files, vitest setup, and API usage all look correct.

Issues found (1):

  1. Unused dependency @fixture/shared — declared in package.json (line 16) but never imported in any source or test file. Since this fixture is intended as a user-facing recipe, the dependency list should only include what's actually used. Posted a suggestion comment to remove it.

Review posted at: #14108 (review)

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 29, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14108

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14108

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14108

miniflare

npm i https://pkg.pr.new/miniflare@14108

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14108

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14108

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14108

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14108

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14108

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14108

wrangler

npm i https://pkg.pr.new/wrangler@14108

commit: 7a85f26

@edmundhung edmundhung force-pushed the edmundhung/wrangler-create-server-receipes branch from d6068a6 to 9eb77e1 Compare May 29, 2026 13:07
@edmundhung edmundhung changed the title chore: add create-server fixture chore: add create-server-example fixture May 29, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 29, 2026

⚠️ No Changeset found

Latest commit: 7a85f26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants