[wrangler] fix: write skills banner to stderr in non-interactive shells#14097
Open
matingathani wants to merge 3 commits into
Open
[wrangler] fix: write skills banner to stderr in non-interactive shells#14097matingathani wants to merge 3 commits into
matingathani wants to merge 3 commits into
Conversation
The non-interactive branch of maybeInstallCloudflareSkillsGlobally used logger.log (stdout) to print the Cloudflare agent skills banner. This contaminated the output of commands like `wrangler deploy --json | jq`, causing jq to fail with a parse error because the banner prefixed the JSON. Changed to logger.warn so the banner goes to stderr, leaving stdout clean for structured output consumers. Fixes cloudflare#14036.
🦋 Changeset detectedLatest commit: 4e4bcc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14036.
maybeInstallCloudflareSkillsGloballyusedlogger.log(stdout) for the non-interactive informational banner. When users pipe wrangler output (e.g.wrangler deploy --json | jq), the banner prefixes the JSON and causesjqto fail:The root cause: the non-interactive branch (
!isInteractive() && !ci.isCI) is exactly the shape of a scripted invocation from an operator shell. The banner is informational — it belongs on stderr like every other non-data message.Fix:
logger.log→logger.warnin the non-interactive branch ofmaybeInstallCloudflareSkillsGlobally.logger.warnroutes toconsole.warn(stderr), leaving stdout clean for JSON consumers. The interactive install path (line ~133) keepslogger.logsince that targets a TTY user.