In C3 hide non-framework categories when --platform=pages is specified#14095
Open
dario-piotrowicz wants to merge 1 commit into
Open
In C3 hide non-framework categories when --platform=pages is specified#14095dario-piotrowicz wants to merge 1 commit into
--platform=pages is specified#14095dario-piotrowicz wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 6f3707c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ All changesets look good |
5e2bed9 to
8880c12
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
8880c12 to
1960130
Compare
14fcf96 to
6f3707c
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
NuroDev
approved these changes
May 29, 2026
| }); | ||
|
|
||
| describe.skipIf(isExperimental)("platform filtering", () => { | ||
| test.skipIf(isWindows)( |
Member
There was a problem hiding this comment.
What is the reasoning for skipping on Windows here?
workers-devprod
approved these changes
May 29, 2026
Contributor
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.cfdata.org/browse/DEVX-2432
When running C3 with
--platform=pages, the "Hello World example" and "Application Starter" categories are now hidden since they only produce Workers projects. The framework list is also filtered to only show frameworks that support the Pages platform. This makes it clear that C3 can only create Pages projects when using a framework.A picture of a cute animal (not mandatory, but encouraged)