Fix json serialization but in mapWorkerMetadataBindings and add missing unit tests#14084
Fix json serialization but in mapWorkerMetadataBindings and add missing unit tests#14084dario-piotrowicz wants to merge 2 commits into
mapWorkerMetadataBindings and add missing unit tests#14084Conversation
…tadataBindings` functions
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Review posted successfully. Here's a summary of my findings: One actionable issue found: The test for the |
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
🦋 Changeset detectedLatest commit: 12a4692 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ All changesets look good |
makeWorkerConfig and mapWorkerMetadataBindings functionsmapWorkerMetadataBindings and add missing unit tests
|
Codeowners approval required for this PR:
Show detailed file reviewers |
petebacondarwin
left a comment
There was a problem hiding this comment.
Has this been broken for a long time??
| expect(result.main).toBe("index.js"); | ||
| }); | ||
|
|
||
| it("accepts an array with one worker", ({ expect }) => { |
There was a problem hiding this comment.
Should it also accept multiple workers?
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Fixes https://jira.cfdata.org/browse/DEVX-2344
This PR adds fixes
mapWorkerMetadataBindingsnot correctly mapping json bindings and it also adds test coverage for themakeWorkerConfigandmapWorkerMetadataBindingsutilitiesA picture of a cute animal (not mandatory, but encouraged)