vhost-user-block: Fix get_config interopability#7617
Merged
rbradford merged 2 commits intocloud-hypervisor:mainfrom Jan 20, 2026
Merged
vhost-user-block: Fix get_config interopability#7617rbradford merged 2 commits intocloud-hypervisor:mainfrom
rbradford merged 2 commits intocloud-hypervisor:mainfrom
Conversation
Member
rbradford
commented
Jan 19, 2026
- virtio-devices: vhost-user: blk: Use zero configuration offset
- vhost-user-block: Return subset of config space requested
Based upon the discussion and in rust-vmm/vhost#29 (comment) and the QEMU behaviour the get_config offset should be zero. This was not caught by our integration tests as the vhost-user-blk backend as implemented in this repository does not use the offset. Fixes: cloud-hypervisor#7615 Signed-off-by: Rob Bradford <rbradford@meta.com>
310a176 to
f70770e
Compare
The spec says simply that that an empty payload should be returned on error. Be slightly more helpful by adding a warning. Signed-off-by: Rob Bradford <rbradford@meta.com>
f70770e to
ff2644a
Compare
phip1611
approved these changes
Jan 20, 2026
Member
phip1611
left a comment
There was a problem hiding this comment.
LGTM!
PS: Also seeing your @meta.com> for the first time now, nice 😎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.