Add gh pr close <numberOrURL> - #854
Merged
Merged
Conversation
Contributor
|
Works well, nice job. Would be is it worth saying if a PR was closed and merged? As "closed" doesn't imply it was merged, it answers the question "what happened to that PR?". Example: Of course this could also open the door to what type of merge: rebase, squash, etc... and users have |
Contributor
Author
|
@tierninho I like the idea of including merged state. But "merged and closed" seems a little redundant? Maybe "Pull request #66 was merged" or "Pull request #66 was already closed" or is that too confusing? |
Contributor
mislav
approved these changes
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
gh pr closeit looks like this 👇Closes third of four features in #413