Skip to content

repo delete: change confirmation flag to --yes - #6911

Merged
mislav merged 9 commits into
cli:trunkfrom
damiensedgwick:fix/#6892-update-confirmation-flag-on-delete
Jan 25, 2023
Merged

repo delete: change confirmation flag to --yes#6911
mislav merged 9 commits into
cli:trunkfrom
damiensedgwick:fix/#6892-update-confirmation-flag-on-delete

Conversation

@damiensedgwick

@damiensedgwick damiensedgwick commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

Ref. #6892

Passed an additional flag --yes to the delete command and marked --confirm as deprecated.

Comment thread pkg/cmd/repo/delete/delete.go Outdated
Comment thread pkg/cmd/repo/delete/delete.go Outdated
@damiensedgwick

Copy link
Copy Markdown
Contributor Author

hmm I appear to have picked up a linting error, let me try and figure this out.

@damiensedgwick
damiensedgwick marked this pull request as ready for review January 25, 2023 15:38
@damiensedgwick
damiensedgwick requested a review from a team as a code owner January 25, 2023 15:38
@damiensedgwick
damiensedgwick requested review from samcoe and removed request for a team January 25, 2023 15:38
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Jan 25, 2023
@damiensedgwick
damiensedgwick requested review from mislav and removed request for samcoe January 25, 2023 15:38

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mislav mislav changed the title Add additional confirmation flag for deleting repositories repo delete: change confirmation flag to --yes Jan 25, 2023
@mislav
mislav merged commit 55053df into cli:trunk Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants