select base repo correctly when only one remote - #6803

Maybe this is an obscure edge case but what about a case where there are multiple remotes and they only resolve to a single repo? Returning r.remotes[0] seems like it could result in the wrong remote getting selected. What about:

// Maintain current behavior in this case.
if len(repos) == 0 {
    return r.remotes[0], nil
}

if len(repos) == 1 {
    return repos[0], nil
}

I'm not worried about it. The shape of the RepoNetwork is directly related to the list of remotes locally. Multiple remotes all resolving to a single repo is a strange enough edge-case that I don't think we have to handle it.

That one does seem unlikely. What about:

Remote 0 -> does not resolve to any GitHub repos because of auth issue or it is malformed remote or the repo was archived/deleted/renamed/etc
Remote 1 -> resolves to one GitHub repo

This is the one I was more concerned about. Normally you would think that an error would pop up and we wouldn't reach this point but the RepoNetwork query tolerates repo not found errors and so a remote can result in not resolving to any repo at all.

Going to approve the PR as the code looks good. Feel free to address this edge case if you feel it is relevant.

ah, I see, thanks for elaborating; I wasn't interpreting your edge case correctly.

I do think there is merit in handling this after all so I'll push a commit for that.