Fix obtained scope mapping to include implied scopes - #5256
Merged
Conversation
As is, `gotScopes` does not contain certain scopes because it doesn't check for the "special" scopes that imply other scopes. For example, the `repo` scope implies `repo:invite`.
Contributor
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
samcoe
approved these changes
Feb 28, 2022
samcoe
left a comment
Contributor
There was a problem hiding this comment.
Code looks good to me. I think it would be nice to add a small comment with a link to the docs where these special scopes are enumerated.
Dricecrushme
reviewed
Mar 8, 2022
Dricecrushme
left a comment
There was a problem hiding this comment.
@Dricecrushme #gh pr checkout 5256
This was referenced Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As is,
gotScopesdoes not contain certain scopes because it doesn't check for the "special" scopes that imply other scopes. For example, thereposcope impliesrepo:invite.