Skip to content

BREAKING: lookup all issue/PR labels with "AND" instead of "OR" - #3295

Merged
mislav merged 1 commit into
trunkfrom
labels-and-combinator
Mar 30, 2021
Merged

BREAKING: lookup all issue/PR labels with "AND" instead of "OR"#3295
mislav merged 1 commit into
trunkfrom
labels-and-combinator

Conversation

@mislav

@mislav mislav commented Mar 24, 2021

Copy link
Copy Markdown
Contributor

This switches to the Search API whenever any labels are specified in issue list or pr list. This ensures that the results match those that would be returned in the web UI.

This is a breaking change. It will change the results currently returned from commands like gh issue list -l one -l two. We believe that the prior behavior was a bug, and we decided that a breaking change is in order to align with GitHub web behavior.

If you need to combine labels with "OR", you can combine the output of gh issue list -l one; gh issue list -l two and remove the duplicates.

Fixes #419, fixes #1819, ref. #641

@mislav
mislav requested a review from a team March 24, 2021 17:00
…nator

This switches to the Search API whenever labels are specified in `issue
list` or `pr list`. This ensures that the results match those that would
be returned in the web UI.
@mislav
mislav force-pushed the labels-and-combinator branch from ad95e28 to 949df38 Compare March 24, 2021 17:04
Comment thread pkg/cmd/pr/list/http.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue searches with label are case-sensitive BUG: gh pr list and issue list --label uses OR logic instead of AND logic

2 participants