Skip to content

Restore automatic spam issue closure - #14088

Merged
williammartin merged 3 commits into
trunkfrom
williammartin-restore-spam-triage
Aug 6, 2026
Merged

Restore automatic spam issue closure#14088
williammartin merged 3 commits into
trunkfrom
williammartin-restore-spam-triage

Conversation

@williammartin

@williammartin williammartin commented Aug 6, 2026

Copy link
Copy Markdown
Member

Description

The issue-triage agent correctly emits suspected-spam without suggest, but gh-aw v0.83.4 sends metadata-bearing labels through the REST label endpoint. GitHub accepts that request without applying the label, so the existing label-triggered spam closer never runs.

This is tracked upstream in github/gh-aw#50631, where the safe-output artifact shows labelsAdded populated while the before and after label sets remain empty. github/gh-aw#50637 fixes the regression, and the v0.85.4 release notes explicitly list “Fixed add_labels silently applying no labels.”

Regenerate the workflow with gh-aw v0.85.4, which routes labels containing issue-intent metadata through GraphQL. This restores direct suspected-spam application and therefore the existing comment, needs-triage removal, and issue closure behavior.

How did you test this change?

  • gh aw compile --dir .github/workflows --validate: 1 workflow succeeded with 0 warnings in an isolated repository; the generated lockfile matches the committed lockfile.
  • Verified all five setup actions pin gh-aw v0.85.4 (2709137ea6c5b0e19aa621454dc643ea8dc526b1).
  • Verified direct spam-label instructions and the existing label-triggered closer remain unchanged.
  • Verified the v0.85.4 Report failed jobs step is absent after explicitly preserving the v0.83.4 reporting behavior.
  • go test ./... fails identically at base commit 5c39f803f and on this branch in existing git/auth configuration tests.
  • make lint fails identically at base commit 5c39f803f and on this branch with three existing govet reflect.Ptr diagnostics.

Key points

  • Spam classification, criteria, confidence behavior, and issue-only scope are unchanged.
  • Explicitly preserve noop.report-as-issue: true, whose implicit default changed in gh-aw v0.85.4.
  • Explicitly disable v0.85.4’s new failed-job reporter rather than expanding the triage App’s permissions.
  • No pull request triage behavior is added or changed.

Notes for reviewers

Start with .github/workflows/issue-triage.md, then confirm the generated .github/workflows/issue-triage.lock.yml pins gh-aw v0.85.4. This is a follow-up to #14027.

Authorship and follow-up

Who wrote this:

  • A human wrote it.
  • An agent wrote it under close human direction.
  • An agent wrote it independently, and no human has guided the implementation beyond the initial prompt.

Who answers review comments:

  • @username will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted.
  • Nobody has explicitly committed to replying.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e00d0ec3-c3d6-4ee7-9100-a7f294fe2402
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e00d0ec3-c3d6-4ee7-9100-a7f294fe2402
Copilot AI lite review requested due to automatic review settings August 6, 2026 10:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the agentic issue-triage workflow to restore automatic spam issue closure by regenerating the compiled workflow with gh-aw v0.85.4 (so labels carrying issue-intent metadata are applied via GraphQL), and preserves the prior noop reporting behavior that changed across runtime versions.

Changes:

  • Preserve legacy behavior by explicitly setting noop.report-as-issue: true in the workflow frontmatter.
  • Regenerate .github/workflows/issue-triage.lock.yml to pin gh-aw v0.85.4 and pick up the newer compiled job wiring (including updated images/scripts and new failure-reporting behavior).
Show a summary per file
File Description
.github/workflows/issue-triage.md Adds explicit noop.report-as-issue: true to preserve prior reporting behavior after the gh-aw upgrade.
.github/workflows/issue-triage.lock.yml Regenerated lockfile compiled by gh-aw v0.85.4, updating pinned action SHAs/images and compiled workflow logic.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread .github/workflows/issue-triage.lock.yml
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e00d0ec3-c3d6-4ee7-9100-a7f294fe2402
@williammartin
williammartin marked this pull request as ready for review August 6, 2026 10:42
@williammartin
williammartin requested a review from a team as a code owner August 6, 2026 10:42
@williammartin
williammartin requested a review from sergiou87 August 6, 2026 10:42
@williammartin
williammartin merged commit 1cb245f into trunk Aug 6, 2026
23 checks passed
@williammartin
williammartin deleted the williammartin-restore-spam-triage branch August 6, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants