Closed
Conversation
vilmibm
self-requested a review
August 19, 2020 16:31
vilmibm
suggested changes
Aug 19, 2020
vilmibm
left a comment
Contributor
There was a problem hiding this comment.
Thanks for starting on this!
I'd rather see a UX that is more consistent with our other commands, like:
Attached to a TTY:
$ gh pr close 123
? Would you like to leave a comment?
Close
> Close with comment
? Comment body [(e) to launch vim]
? Submit [Y/n]
# closes PR with editor-provided comment
$ gh pr close 123
? Would you like to leave a comment?
> Close
Close with comment
# closes PR with no comment; confirm not needed here
$ gh pr close 123 --comment "foo"
# closes pr, comments "foo"
Unattached to a TTY:
$ gh pr close 123
# closes pr, no comment
$ gh pr close 123 --comment "foo"
# closes pr, comments "foo"
$ gh pr close 123 --comment ""
# closes pr, no prompt for comment, no comment
Contributor
|
I'm going to close this as it's gotten rather old; please feel free to re-open as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #1038
Details
This will add "--comment" option on pr close and pr reopen;