Revert to ignoring non-github.com git remotes#1371
Merged
Conversation
This fixes a regression where extra git remotes pointing to non-github.com hostnames could result in gh trying to parse repository information from them.
vilmibm
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression where extra git remotes pointing to non-
github.comhostnames could result in gh trying to parse repository information from them.To reproduce:
This reverts to simply ignoring non-
github.comremotes. We do have better support for other hostnames now, but until we decide on specific onboarding logic for dealing with mixed remotes #1180, it's best to ignore them for now to avoid causing disruption to our users.Followup to #1258