SPIKE(snowflake): begin of some whitespace preservation - #1
Open
cchepelov wants to merge 1 commit into
Open
Conversation
This was referenced Mar 12, 2024
cchepelov
force-pushed
the
chore/migrate-to-peggyjs
branch
from
March 12, 2024 06:09
b9ce1ec to
c195348
Compare
cchepelov
force-pushed
the
feat/preserve-whitespace-experiment
branch
from
March 12, 2024 06:10
53afd3a to
ccb7607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a time-boxed discovery experiment of what it would take to support preservation of whitespace.
I've concentrated on snowflake, and appear to have broken about everything else...
__and___would need to be bound to a return variable and consumed at the right time during the conversion of AST back to SQL.__and___should instead be returned to''or' 'as currently... but in a "smart" wayfrom_clausethat currently return a list would become inconvenient; as we would need to:it's not unfeasible, but it is, unfortunately, a far more complex exercise than what I can commit at this moment.
I hope this is helpful!