feature:change getconfig impl to cache locally and update by polling … - #77
Merged
kevinten10 merged 3 commits intoDec 28, 2021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
============================================
- Coverage 33.92% 32.14% -1.79%
+ Complexity 70 69 -1
============================================
Files 25 25
Lines 731 728 -3
Branches 74 73 -1
============================================
- Hits 248 234 -14
- Misses 468 480 +12
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
…pa-aws into feature_modify_getconfig_impl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…periodly
Description
当前getconfig是直接调用appconfig sdk获取配置，频繁使用会使用调用费用昂贵。接入方可能不理解此方法的真实使用场景，进行滥用，导致费用飙升。现将里面的逻辑改成和subscribe逻辑一致，自己维护配置的更新，每次返回配置，从本地拉取。
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #76
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: