Skip to content

refactor: refactor spi class loader - #24

Merged
kevinten10 merged 7 commits into
masterfrom
refactor/classLoader
Nov 30, 2021
Merged

refactor: refactor spi class loader#24
kevinten10 merged 7 commits into
masterfrom
refactor/classLoader

Conversation

@kevinten10

Copy link
Copy Markdown
Member

Description

refactor spi class loader

Issue reference

capa-cloud/capa-java#48

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@codecov-commenter

codecov-commenter commented Nov 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #24 (982bf7d) into master (45b3bb1) will decrease coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #24      +/-   ##
============================================
- Coverage     77.62%   77.12%   -0.51%     
  Complexity       78       78              
============================================
  Files            15       15              
  Lines           371      376       +5     
  Branches         25       27       +2     
============================================
+ Hits            288      290       +2     
- Misses           60       61       +1     
- Partials         23       25       +2     
Impacted Files Coverage Δ
...up/rxcloud/capa/spi/aws/mesh/http/AwsCapaHttp.java 86.11% <0.00%> (-7.83%) ⬇️
...spi/aws/config/AwsCapaConfigurationProperties.java 100.00% <0.00%> (ø)
.../capa/spi/aws/mesh/config/AwsSpiOptionsLoader.java
...capa/spi/aws/mesh/config/AwsRpcServiceOptions.java
...spi/aws/mesh/http/config/AwsRpcServiceOptions.java 96.55% <0.00%> (ø)
.../spi/aws/mesh/http/config/AwsSpiOptionsLoader.java 100.00% <0.00%> (ø)
...xcloud/capa/spi/aws/config/AwsCapaConfigStore.java 77.38% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b3bb1...982bf7d. Read the comment docs.

@kevinten10

Copy link
Copy Markdown
Member Author

LGTM.

@kevinten10
kevinten10 merged commit 8399d6c into master Nov 30, 2021
@kevinten10
kevinten10 deleted the refactor/classLoader branch November 30, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants